Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of WARNING logs #102

Closed
bachya opened this issue Mar 25, 2019 · 2 comments
Closed

Lots of WARNING logs #102

bachya opened this issue Mar 25, 2019 · 2 comments
Labels

Comments

@bachya
Copy link
Contributor

bachya commented Mar 25, 2019

Submitting on behalf of an issue discovered by the use of this library (and python-socketio) in Home Assistant: home-assistant/core#22295

We are receiving lots of these WARNING-level entries in our logs:

2019-03-22 12:07:38 WARNING (MainThread) [engineio.client] Read loop: WebSocket connection was closed, aborting
2019-03-22 12:07:38 WARNING (MainThread) [engineio.client] Write loop: WebSocket connection was closed, aborting

From my understanding (and previous work with you), I expect these occur when the client gets unexpectedly disconnected from the socket. Since the client automatically reconnects, there isn't any user-facing impact – they merely see large amounts of "nothing to worry about" logs.

Would you consider taking this to INFO level if a reconnect is successful? Open to other alternatives and thoughts.

@miguelgrinberg
Copy link
Owner

I'm okay with downgrading these messages to INFO, that seems reasonable. Do you wan to create a PR for this change?

@bachya
Copy link
Contributor Author

bachya commented Mar 25, 2019

Will do! Is there other logging – here or in python-socketio – that you feel falls under the same banner (i.e., because the end-result was taken care of, WARNING is too steep)? If so, happy to adjust via PR, as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants