Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better exception handling for errors thrown by the websocket-clie… #155

Merged
merged 2 commits into from
Dec 13, 2019
Merged

Add better exception handling for errors thrown by the websocket-clie… #155

merged 2 commits into from
Dec 13, 2019

Conversation

harmon
Copy link
Contributor

@harmon harmon commented Dec 12, 2019

…nt library.

@miguelgrinberg
Copy link
Owner

miguelgrinberg commented Dec 13, 2019 •
edited
Loading

What is the situation where this exception is raised?

Edit: Sorry, now I see that you wrote issue #154

@miguelgrinberg miguelgrinberg merged commit 33c7cf1 into miguelgrinberg:master Dec 13, 2019
@miguelgrinberg
Copy link
Owner

Looks good, thank you!

@harmon
Copy link
Contributor Author

harmon commented Dec 13, 2019

Awesome, thanks! I couldn't figure out the best way to link to the issue, maybe reference in the git commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harmon @miguelgrinberg