Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user input from Bad Request responses #250

Merged

Conversation

RedRoserade
Copy link
Contributor

As discussed via e-mail, this PR removes user-input from the HTTP Bad Request responses that result from invalid transports or session IDs.

All unit tests seem to pass locally.

@miguelgrinberg miguelgrinberg self-assigned this Sep 28, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #250 (b84be34) into main (c2603e9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #250   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         1894      1894           
  Branches       343       343           
=========================================
  Hits          1894      1894           
Impacted Files Coverage Δ
src/engineio/server.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2603e9...b84be34. Read the comment docs.

@miguelgrinberg miguelgrinberg merged commit 72b7136 into miguelgrinberg:main Sep 28, 2021
@miguelgrinberg
Copy link
Owner

Thank you so much!

@RedRoserade RedRoserade deleted the escape-badrequest-args branch September 28, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants