Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lifespan when running with other_asgi_app #284

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

mozartilize
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #284 (fe27eea) into main (9c65707) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #284   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         1934      1934           
  Branches       377       377           
=========================================
  Hits          1934      1934           
Impacted Files Coverage Δ
src/engineio/async_drivers/asgi.py 100.00% <100.00%> (ø)
src/engineio/asyncio_server.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@miguelgrinberg miguelgrinberg merged commit c4a021e into miguelgrinberg:main Jul 1, 2022
@miguelgrinberg
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants