Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make timestamp parameter t optional #386

Closed
miguelgrinberg opened this issue Nov 24, 2024 Discussed in #385 · 0 comments
Closed

Make timestamp parameter t optional #386

miguelgrinberg opened this issue Nov 24, 2024 Discussed in #385 · 0 comments
Assignees

Comments

@miguelgrinberg
Copy link
Owner

Discussed in #385

Originally posted by PaxxPatriot November 24, 2024
According to the JavaScript socket.io documentation, there is an option to deactivate the addition of the cache-busting timestamp parameter: https://socket.io/docs/v4/client-options/#timestamprequests

This is also reflected in the JavaScript code here: https://github.com/socketio/socket.io/blob/main/packages/engine.io-client/lib/transports/websocket.ts#L142. It is also disabled by default.

The behaviour of the current python-engineio implementation was blocking me from using socket.io with the Skinport socket.io Server.
So my suggestion is to make it possible to disable the addition of this parameter to the initial request URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant