redis pub/sub support set password #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At first I added it to URL, but it was not easy to handle when the password value was None, so I added a parameter "password"
|
I'm in the middle of a long trip back home today, I'll review this in a day or two. Thanks! |
|
sorry,When do you plan to join this function? |
|
@Larry-Dev did you notice that the automated build is failing with your changes? Do you have time to fix those problems, or do you want me to? I can't merge this as is. |
added 2 commits
July 20, 2017 16:12
format code style
format code style
|
i fixed those problems.sorry,i didn't notice this error of build |
|
@Larry-Dev I modified your change to include the password in the URL, so that it is consistent with the non-async side. To add a password, use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first I added it to URL, but it was not easy to handle when the password value was None, so I added a parameter "password"