Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rediss:// URL scheme to AsyncRedisManager #319

Merged
merged 2 commits into from
Jul 21, 2019
Merged

Added rediss:// URL scheme to AsyncRedisManager #319

merged 2 commits into from
Jul 21, 2019

Conversation

dbanty
Copy link
Contributor

@dbanty dbanty commented Jul 19, 2019

Closes #318

@miguelgrinberg
Copy link
Owner

Two comments:

  • Could you fix the error from the build?
  • Any chance you can also do the standard (i.e. non-asyncio) Redis manager?

Thanks!

@dbanty
Copy link
Contributor Author

dbanty commented Jul 19, 2019

  • Could you fix the error from the build?

Done I think, waiting on Travis.

  • Any chance you can also do the standard (i.e. non-asyncio) Redis manager?

The standard manager already supports rediss I think. It uses redis.Redis.from_url which supports the scheme ( see here )

@miguelgrinberg
Copy link
Owner

Ay yes, the URLs are fully handled by the Redis client for the non-asyncio case. Great.

@miguelgrinberg miguelgrinberg merged commit 0b25ff4 into miguelgrinberg:master Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AsyncRedisManager SSL Support
2 participants