Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncServer cors_allowed_origins docs incorrecr #327

Closed
dbanty opened this issue Aug 1, 2019 · 2 comments
Closed

AsyncServer cors_allowed_origins docs incorrecr #327

dbanty opened this issue Aug 1, 2019 · 2 comments
Assignees

Comments

@dbanty
Copy link
Contributor

dbanty commented Aug 1, 2019

I believe the docs for the AsyncServer class are incorrect. They state "cors_allowed_origins – List of origins that are allowed to connect to this server. All origins are allowed by default." All origins means to me that the default is '', but that doesn't seem to be the case. Only the same origin was allowed to make requests by default, I had to explicitly set cors_allowed_origins='' in the AsyncServer constructor to allow all.

I think this is probably the right choice for a default (more secure) but the docs should properly indicate the behavior.

@miguelgrinberg
Copy link
Owner

This changed recently, I think there must be a problem with my documentation builds, the docs should reflect the current state.

@miguelgrinberg
Copy link
Owner

Actually no, you are correct, I forgot to update the docs on this particular change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants