Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security issue. "Connect to namespace" executes on client side #333

Closed
vldpro opened this issue Aug 8, 2019 · 1 comment
Closed

Security issue. "Connect to namespace" executes on client side #333

vldpro opened this issue Aug 8, 2019 · 1 comment
Assignees
Labels

Comments

@vldpro
Copy link

vldpro commented Aug 8, 2019

Thanks for fix in #325 , but it will not work if client has version less than 4.3.1 and server on 4.3.1.
So, I still can emit events to a namespace without passing "on_connect" handler. I think it should be handled on server side, instead of client side.

@miguelgrinberg
Copy link
Owner

I have to check how the reference server implementation behaves on this situation. The Socket.IO protocol does not prevent unconnected or even non-existing namespaces to be used in events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants