Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aioredis now included in redis-py, please update imports #911

Closed
sfarestam opened this issue Apr 15, 2022 · 0 comments
Closed

aioredis now included in redis-py, please update imports #911

sfarestam opened this issue Apr 15, 2022 · 0 comments

Comments

@sfarestam
Copy link

Note that aioredis is now included in redis-py (see https://github.com/aio-libs/aioredis-py), this means that this import in socketio/asyncio_redis_manager.py:

try:
    import aioredis
except ImportError:
    aioredis = None

can be updated to:

try:
    from redis import asyncio as aioredis
except ImportError:
    aioredis = None

or perhaps:

try:
    from redis import asyncio as aioredis
except ImportError:
    try:
        import aioredis
    except ImportError:
        aioredis = None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant