From 83d61e0657581ed057d8037b98a926452a204487 Mon Sep 17 00:00:00 2001 From: Lucas Wiman Date: Tue, 10 Oct 2023 15:55:46 -0700 Subject: [PATCH] Update `ping_timeout` docs to accord with engineio behavior See: https://github.com/miguelgrinberg/python-engineio/blob/5c996bec85d864526fe41569438a6e15e4a53123/src/engineio/async_server.py#L30-L32 https://github.com/miguelgrinberg/python-engineio/blob/5c996bec85d864526fe41569438a6e15e4a53123/src/engineio/server.py#L31-L33 Those docstrings correctly reflect the defaults, which are defined here: https://github.com/miguelgrinberg/python-engineio/blob/5c996bec85d864526fe41569438a6e15e4a53123/src/engineio/base_server.py#L22 --- src/socketio/async_server.py | 2 +- src/socketio/server.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/socketio/async_server.py b/src/socketio/async_server.py index b39ae86b..f3bb8f8c 100644 --- a/src/socketio/async_server.py +++ b/src/socketio/async_server.py @@ -64,7 +64,7 @@ class AsyncServer(base_server.BaseServer): is a grace period added by the server. :param ping_timeout: The time in seconds that the client waits for the server to respond before disconnecting. The default - is 5 seconds. + is 20 seconds. :param max_http_buffer_size: The maximum size of a message when using the polling transport. The default is 1,000,000 bytes. diff --git a/src/socketio/server.py b/src/socketio/server.py index 89a6b9e3..275e5308 100644 --- a/src/socketio/server.py +++ b/src/socketio/server.py @@ -73,7 +73,7 @@ class Server(base_server.BaseServer): is a grace period added by the server. :param ping_timeout: The time in seconds that the client waits for the server to respond before disconnecting. The default - is 5 seconds. + is 20 seconds. :param max_http_buffer_size: The maximum size of a message when using the polling transport. The default is 1,000,000 bytes.