Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any straight forward way to connect this with BrowserWindow notifications with Electron on Windows? #69

Closed
lipis opened this issue Oct 6, 2015 · 4 comments

Comments

@lipis
Copy link

lipis commented Oct 6, 2015

So notifications work out of the box on OS X, but not on Windows.

I managed to display show notifications on demand (with WindowsToaster but it could be with anything I guess) but how could we connect that with the notifications that are coming from the BrowserWindow?

@mikaelbr
Copy link
Owner

mikaelbr commented Oct 6, 2015

I'm unsure what you mean. I've never used electron to a big extent, and don't know what you mean with connecting notifications from BrowserWindow to node-notifier.

Are thinking of using node-notifier as a fallback for electron notifications on Windows? In that case I'd say the best way would be to make your own abstraction of notification on top of Electron (just a function) that checks if you're on Windows or not. If on windows, use node-notifier.

Or you could just use node-notifier and let it handle all fallbacks and platform checking.

@lipis
Copy link
Author

lipis commented Oct 6, 2015

I was hoping to be able to subscribe somehow when the notification is being fired.. but it's not doable so I'll close this one for now. Thanks.

@lipis lipis closed this as completed Oct 6, 2015
@seriema
Copy link

seriema commented Nov 8, 2015

@lipis I created electron-notification-shim for exactly that purpose. It's really easy to use, just subscribe to notification-shim events in your main process. Bounce them back to the view if you want with the events returnValue or sender.send().

@lipis
Copy link
Author

lipis commented Nov 8, 2015

Will check at one point.. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants