Push to other viewcontroller from BSImagePicker

[cliff357]

Sorry, still have some question on #259,

How can i push to other viewcontroller from BSImagePicker

[mikaoj]

It was supposed to work like that, if it doesn't it's a bug that will have to be looked into.
Feel free to do so :)

[mikaoj]

The problem can likely be fixed in ZoomTransitionDelegate.swift by adding a check that to/from view controllers are the expected AssetsViewController/PreviewViewController. If not don't try to apply the expand/shrink animation.

[cliff357]

Thanks for quick reply, but how can I fix it?
Would you mind to help update?

[cliff357]

Nah, I am now watching ZoomTransitionDelegate, hope I can do something on this issue :D

[mikaoj]

1. Fork this repo.
2. Clone your fork to your computer.
3. Open BSImagePicker.xcworkspace.
4. Do what I said in my previous message.
5. Test that it works as expected.
6. Commit.
7. Push.
8. Create a pull-request from your fork to this repo.

Have a look at ZoomTransitionDelegate.swift
Specifically this part:

extension ZoomTransitionDelegate: UINavigationControllerDelegate {
    public func navigationController(_ navigationController: UINavigationController, animationControllerFor operation: UINavigationController.Operation, from fromVC: UIViewController, to toVC: UIViewController) -> UIViewControllerAnimatedTransitioning? {
        switch operation {
        case .none:
            return nil
        case .push:
            return expandAnimator
        case .pop:
            return shrinkAnimator
        @unknown default:
            return nil
        }
    }
    
    public func navigationController(_ navigationController: UINavigationController, interactionControllerFor animationController: UIViewControllerAnimatedTransitioning) -> UIViewControllerInteractiveTransitioning? {
        if animationController === expandAnimator {
            return interactionController
        } else {
            return nil
        }
    }
}

I can probably fix it sometime during the week - but if you or anyone else want some easy open-source karma this is up for grabs until then :)

[cliff357]

woooooooooow, thank you very much

[cliff357]

I will try your suggestion, but I do not really trust my understanding of Transition, I think i better wait for your fix haha

[mikaoj]

Something like this might work. With reservation for syntax errors and typos. Just need to make sure that that expand/shrink animation still work with images, videos and live images. And also that what you want to do - push another view controller when pressing done works.

extension ZoomTransitionDelegate: UINavigationControllerDelegate {
    public func navigationController(_ navigationController: UINavigationController, animationControllerFor operation: UINavigationController.Operation, from fromVC: UIViewController, to toVC: UIViewController) -> UIViewControllerAnimatedTransitioning? {
        if operation == .push, toVC is PreviewViewController {
            return expandAnimator
        } else if operation == .pop, fromVC is PreviewViewController {
            return shrinkAnimator
        } else {
            return nil
        }
    }
    
    public func navigationController(_ navigationController: UINavigationController, interactionControllerFor animationController: UIViewControllerAnimatedTransitioning) -> UIViewControllerInteractiveTransitioning? {
        if animationController === expandAnimator {
            return interactionController
        } else {
            return nil
        }
    }
}

[cliff357]

Thanks
But may I ask how to make sure the animation still works with images, videos, and live images?

Sorry for my bad English.

[mikaoj]

Run the example app on your phone.
Long press on an image - is there a nice animation that zooms the image in/out? Great it works!
Do the same for videos and live photos :)

[cliff357]

ohhhhhhhhhhhhhhh, thank you very much
tried this fix, there are some issue,

[mikaoj]

Should be fixed in version 3.1.6 - try it out! :)