feat!: add default colors for hover highlighting #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hover highlighting is now enabled by default === This works with the latest yazi when `use_ya_for_events_reading = true` is specified. To learn more about enabling this, see <#152> This will be the default behaviour when yazi 0.3 is released. Hover highlighting colors no longer require manual configuration === This change adds default colors for the hover highlighting feature. The logic supports both light and dark colorschemes: - for dark colorschemes, the hovered buffer will be lighter in color - for light colorschemes, it will be darker The logic is borrowed from the `bufferline.nvim` plugin, which has a lot of users and is well-maintained. This also adds a dependency to bufferline.nvim, but as an optimization only its color utility functions are used as late as possible, and even they are only used when the user hasn't specified a custom highlight color. BREAKING CHANGE: The optional `hovered_buffer_background` key in the `YaziConfigHighlightGroups` has been renamed to `hovered_buffer`. This change was made to better reflect the purpose of the key. To migrate, run this 🙂 ```vim :%s/hovered_buffer_background/hovered_buffer/gc ```
This was referenced Jul 14, 2024
This was referenced Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hover highlighting is now enabled by default
(Hover highlighting is a feature currently requiring opt-in that was added in #180)
This works with the latest yazi when
use_ya_for_events_reading = trueis specified. To learn more about enabling this, see #152This will be the default behaviour when yazi 0.3 is released.
Hover highlighting colors no longer require manual configuration
autocolors-dark.mov
autocolors-light.mov
This change adds default colors for the hover highlighting feature. The logic supports both light and dark colorschemes:
The logic is borrowed from the
bufferline.nvimplugin, which has a lot of users and is well-maintained. This also adds a dependency to bufferline.nvim, but as an optimization only its color utility functions are used as late as possible, and even they are only used when the user hasn't specified a custom highlight color.The optional
hovered_buffer_backgroundkey in theYaziConfigHighlightGroupshas been renamed tohovered_buffer. This change was made to better reflect the purpose of the key.To migrate, run this 🙂