fix: YaziRenamedOrMoved events could not be published in practice #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue ===== When a file was renamed/moved, a YaziRenamedOrMoved event was supposed to be published. However, the event was not actually published in practice due to `E5560: nvim_exec_autocmds must not be called in a lua loop callback`. Solution ======== The solution was to schedule the event publishing in a `vim.schedule` block. This way, the event publishing is deferred to the next event loop iteration, which avoids the error. For some reason, this error is not visible in unit tests, so I added an integration test to make sure it doesn't break again.
This was referenced Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When a file was renamed/moved, a YaziRenamedOrMoved event was supposed to be published. However, the event was not actually published in practice due to
E5560: nvim_exec_autocmds must not be called in a lua loop callback.Solution
The solution was to schedule the event publishing in a
vim.scheduleblock. This way, the event publishing is deferred to the next event loop iteration, which avoids the error.For some reason, this error is not visible in unit tests, so I added an integration test to make sure it doesn't break again.