Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn off mmap #351

Closed
mistepien opened this issue Aug 4, 2016 · 5 comments
Closed

turn off mmap #351

mistepien opened this issue Aug 4, 2016 · 5 comments

Comments

@mistepien
Copy link

There is automatically mmap used in 2.8.4.5.
Please make a switch to turn it off.

@mistepien
Copy link
Author

btw, are you sure that mmap is good?
see this:
http://git.musicpd.org/cgit/master/mpd.git/commit/?id=8ffcdb73e865ee6aff80db7cfcbdb44884b9ba95

@mikebrady
Copy link
Owner

Thanks for the suggestion. Some devices will not work without mmap. Is it actually causing problems in your situation?

@mistepien
Copy link
Author

In fact I tested it in virtualbox and shairport hanged. Maybe that's a matter of bad luck, whatever.
For sake of support of new devices you change support of devices which already worked. MMAP is turn on automatically so now I have no choice. All I suggest is a switch in command line or in conf file to turn it off.

@mikebrady
Copy link
Owner

Thanks. I'll put it "on the list".

@mikebrady
Copy link
Owner

Pretty sure this has been done – see the configuration file. Thanks for this contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants