diff --git a/pkg/yqlib/operator_multiply.go b/pkg/yqlib/operator_multiply.go index 64922c7240..c4fee2df4e 100644 --- a/pkg/yqlib/operator_multiply.go +++ b/pkg/yqlib/operator_multiply.go @@ -153,6 +153,8 @@ func repeatString(lhs *CandidateNode, rhs *CandidateNode) (*CandidateNode, error count, err := parseInt(intNode.Value) if err != nil { return nil, err + } else if count < 0 { + return nil, fmt.Errorf("Cannot repeat string by a negative number (%v)", count) } target.Value = strings.Repeat(stringNode.Value, count) diff --git a/pkg/yqlib/operator_multiply_test.go b/pkg/yqlib/operator_multiply_test.go index 3305fe8f36..c055491efd 100644 --- a/pkg/yqlib/operator_multiply_test.go +++ b/pkg/yqlib/operator_multiply_test.go @@ -201,6 +201,13 @@ var multiplyOperatorScenarios = []expressionScenario{ fmt.Sprintf("D0, P[], (!!str)::%s\n", strings.Repeat("banana", 4)), }, }, + { + description: "Multiply string X by negative int", + skipDoc: true, + document: `n: -4`, + expression: `"banana" * .n`, + expectedError: "Cannot repeat string by a negative number (-4)", + }, { description: "Multiply int node X string", document: `n: 4