Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vipr] add image extractor #1258

Merged
merged 2 commits into from
Jan 20, 2021
Merged

[vipr] add image extractor #1258

merged 2 commits into from
Jan 20, 2021

Conversation

v-delta
Copy link
Contributor

@v-delta v-delta commented Jan 20, 2021

Adds support for images hosted on https://vipr.im

I couldn't figure out how the tests work. If you give me a hint, I'll be glad to hand them in.

@mikf mikf merged commit e707e06 into mikf:master Jan 20, 2021
mikf added a commit that referenced this pull request Jan 20, 2021
@mikf
Copy link
Owner

mikf commented Jan 20, 2021

Thanks a lot for your contribution.

Tests for all other image host sites are the SHA1 hexdigests for download URL and metadata results. They can be generated with create_test_data.py and the a test URL as argument.

It is also possible to specify an expected URL pattern, values/patterns/types for the keyword dictionary, options, etc like here, but just a hash result is good enough for simple sites.

@v-delta v-delta deleted the vipr_im branch February 9, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants