Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owner_api v3 "create_wallet" return "ok" even receive invalid mnemonic seeds. #292

Closed
xiaojay opened this issue Jan 14, 2020 · 2 comments · Fixed by #319
Closed

owner_api v3 "create_wallet" return "ok" even receive invalid mnemonic seeds. #292

xiaojay opened this issue Jan 14, 2020 · 2 comments · Fixed by #319
Labels
bug Something isn't working
Milestone

Comments

@xiaojay
Copy link

xiaojay commented Jan 14, 2020

Pass invalid seeds to owner_api v3 "create_wallet" still got ""result": {"Ok": null}" response.
Although wallet.seed does not created in fact.

maybe add validate mnemonic code in this line

let _ = WalletSeed::init_file(&data_dir_name, mnemonic_length, mnemonic.clone(), password);

?

@yeastplume
Copy link
Member

Okay, thanks will look into this

@yeastplume
Copy link
Member

Thanks for pointing this out, addressed in #319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants