Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

top_level_dir continues to broken #308

Closed
GHLover opened this issue Jan 21, 2020 · 1 comment · Fixed by #318
Closed

top_level_dir continues to broken #308

GHLover opened this issue Jan 21, 2020 · 1 comment · Fixed by #318
Labels
bug Something isn't working
Milestone

Comments

@GHLover
Copy link

GHLover commented Jan 21, 2020

--top_level_dir continues to be broken and has not really worked since I reported an issue when it was named data_dir in the last versions of grin.

What is the Issue?
--top_level_dir does NOT load the grin-wallet.toml that was defined in the custom directory. Grin will correctly make the grin-wallet.toml in that directory if it does not exist. It will even set all the paths correctly for the api secrets and logging in said generated grin-wallet.toml.

However, it does NOT load the configuration file and utilize it as part of it's configuration and therefore it is impossible to run with a custom config path.

Reproducing The Issue
This can be verified running these two commands (notice the ".grin2" and not ".grin"):

  1. grin -t /home/user/.grin2/ init
  2. grin -t /home/user/.grin2/ info

When (1) is run it will create a wallet_data and grin-wallet.toml file as expected in /home/user/.grin2/. If you look at the grin-wallet.toml file you will see all config options have correctly set paths to /home/user/.grin2/ for everything from the api_secret to the wallet logging.

However, you will notice when running (1) or (2) that grin continues to ignore /home/user/.grin2/grin-wallet.toml. Instead, it will create files in /home/user/.grin/. Running the wallet command will fill the incorrect log path /home/user/.grin/main/grin-wallet.log with information.

This should ALL be put inside of /home/user/.grin2/ and the log should be at /home/user/.grin2/grin-wallet.log. This is where it is defined to be at via the "log_file_path" that grin auto-created when it auto-greated the grin-wallet.toml.

@yeastplume
Copy link
Member

Okay, thanks for the detailed description, will look into it before next release

@yeastplume yeastplume added the bug Something isn't working label Jan 22, 2020
@yeastplume yeastplume added this to the v3.1.0 milestone Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants