Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Offline send #82

Closed
casey opened this issue Feb 4, 2019 · 4 comments
Closed

Feature request: Offline send #82

casey opened this issue Feb 4, 2019 · 4 comments

Comments

@casey
Copy link

casey commented Feb 4, 2019

I'd like to be able to send transactions from a machine without network access, however this doesn't seem to be currently supported. Correct me if I'm wrong, but the finalize command expects to be able to broadcast the finalized transaction immediately, so if the sending wallet is offline, it won't be able to complete the send, receive, finalize sequence.

I think this is valuable for security, since it allows sending funds from secure machine that isn't connected to the internet.

The simplest implementation would be to add an option to finalize to dump the final transaction, which could then be moved to an online machine for broadcast. Or, if #2473 allowed an online-invoice, offline-send, online-finalize flow, that would work too, and would potentially mean one less transfer between machines. (As opposed to an offline-send, online-receive, offline-finalize-dump, online-broadcast flow.)

@casey
Copy link
Author

casey commented Feb 6, 2019

I propose the following implementation:

  • Add grin wallet finalize --output FILE to save a finalized transaction to FILE instead of broadcasting it to the network
  • Add a grin server broadcast --input FILE command to broadcast a finalized transaction to the network. Since no wallet is necessary to broadcast a transaction, we can avoid involving the wallet at all and make this a grin server command.

If this sounds good, I can get cracking on a PR.

@ignopeverell
Copy link

Sounds very reasonable to me.

@Onefox
Copy link

Onefox commented Feb 20, 2019

You would also need to check on the send option since at the moment there is a node needed for that.

Take a look at the discussion here:
mimblewimble/grin#2227

@ignopeverell ignopeverell transferred this issue from mimblewimble/grin Apr 16, 2019
@yeastplume
Copy link
Member

This functionality is in place now via #255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants