-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Offline send #82
Comments
I propose the following implementation:
If this sounds good, I can get cracking on a PR. |
Sounds very reasonable to me. |
You would also need to check on the send option since at the moment there is a node needed for that. Take a look at the discussion here: |
This functionality is in place now via #255 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'd like to be able to send transactions from a machine without network access, however this doesn't seem to be currently supported. Correct me if I'm wrong, but the
finalize
command expects to be able to broadcast the finalized transaction immediately, so if the sending wallet is offline, it won't be able to complete thesend
,receive
,finalize
sequence.I think this is valuable for security, since it allows sending funds from secure machine that isn't connected to the internet.
The simplest implementation would be to add an option to
finalize
to dump the final transaction, which could then be moved to an online machine for broadcast. Or, if #2473 allowed an online-invoice, offline-send, online-finalize flow, that would work too, and would potentially mean one less transfer between machines. (As opposed to an offline-send, online-receive, offline-finalize-dump, online-broadcast flow.)The text was updated successfully, but these errors were encountered: