Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[notebooks] Add a notebook tutorial on artefact detection #732

Closed
fg-mindee opened this issue Dec 20, 2021 · 5 comments · Fixed by #755
Closed

[notebooks] Add a notebook tutorial on artefact detection #732

fg-mindee opened this issue Dec 20, 2021 · 5 comments · Fixed by #755
Assignees
Labels
topic: documentation Improvements or additions to documentation topic: object detection Related to the task of object detection type: enhancement Improvement
Milestone

Comments

@fg-mindee
Copy link
Contributor

The artefact detection feature is a really nice one, and we should help users to leverage it in the most efficient way. I believe that a notebook tutorial would be a good way to do so, what do you think @SiddhantBahuguna?

@fg-mindee fg-mindee added topic: documentation Improvements or additions to documentation type: enhancement Improvement topic: object detection Related to the task of object detection labels Dec 20, 2021
@fg-mindee fg-mindee added this to the 0.6.0 milestone Dec 20, 2021
@SiddhantBahuguna
Copy link
Contributor

I completely agree with you. I am on it!
Thanks :)

@fg-mindee
Copy link
Contributor Author

Now that mindee/notebooks#5 has been merged, would you mind opening a PR here to add a new row in this table https://github.com/mindee/doctr/blob/main/notebooks/README.md ? :)

That will automatically deploy it in the documentation (https://mindee.github.io/doctr/latest/notebooks.html)

@SiddhantBahuguna
Copy link
Contributor

Now that mindee/notebooks#5 has been merged, would you mind opening a PR here to add a new row in this table https://github.com/mindee/doctr/blob/main/notebooks/README.md ? :)

That will automatically deploy it in the documentation (https://mindee.github.io/doctr/latest/notebooks.html)

Thanks for the further guidance!
A PR has been opened:)

@fg-mindee
Copy link
Contributor Author

The issue shouldn't be closed before the PR is merged!

@fg-mindee fg-mindee reopened this Dec 25, 2021
@SiddhantBahuguna
Copy link
Contributor

The issue shouldn't be closed before the PR is merged!

Oh my bad :) Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Improvements or additions to documentation topic: object detection Related to the task of object detection type: enhancement Improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants