From e7ed2c6efa4ebbe2562265bdff5f7cbd3223b139 Mon Sep 17 00:00:00 2001 From: fg-mindee Date: Thu, 21 Oct 2021 18:35:45 +0200 Subject: [PATCH 1/2] chore: Updated httpx version constraints --- api/requirements-dev.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/requirements-dev.txt b/api/requirements-dev.txt index 06425d733a..250adc4063 100644 --- a/api/requirements-dev.txt +++ b/api/requirements-dev.txt @@ -1,4 +1,4 @@ pytest>=5.3.2 pytest-asyncio>=0.14.0 asyncpg>=0.20.0 -httpx>=0.16.1 +httpx>=0.16.1,<0.20.0 From 22a4677dd9f7a2fce71c3b8383e125b5054045da Mon Sep 17 00:00:00 2001 From: fg-mindee Date: Thu, 21 Oct 2021 18:36:02 +0200 Subject: [PATCH 2/2] docs: Added comments on conftest about httpx pin --- api/tests/conftest.py | 1 + 1 file changed, 1 insertion(+) diff --git a/api/tests/conftest.py b/api/tests/conftest.py index 2164a8b50f..14ae4da918 100644 --- a/api/tests/conftest.py +++ b/api/tests/conftest.py @@ -24,5 +24,6 @@ def mock_detection_image(tmpdir_factory): @pytest.fixture(scope="function") async def test_app_asyncio(): + # for httpx>=20, follow_redirects=True (cf. https://github.com/encode/httpx/releases/tag/0.20.0) async with AsyncClient(app=app, base_url="http://test") as ac: yield ac # testing happens here