Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the deps ingester to work on PRs #5167

Closed
evankanderson opened this issue Dec 9, 2024 · 0 comments · Fixed by #5168
Closed

Allow the deps ingester to work on PRs #5167

evankanderson opened this issue Dec 9, 2024 · 0 comments · Fixed by #5168

Comments

@evankanderson
Copy link
Member

Please describe the enhancement

It should be possible to use the deps ingestion mechanism with PRs. This could have a few possible modes:

  • Return all dependencies from the PR branch (i.e. "must keep head good, even if you didn't change it")
  • Return only new dependencies from the PR branch (i.e. "don't introduce new problems")
  • Return new and updated dependencies from the PR branch (i.e. "you touched it, you need to fix it")

Solution Proposal

Extend the current deps ingestion, which errors when applied in contexts other than repository to also support pull_request context.

Describe alternatives you've considered

  • Adding a new ingester. (This adds new syntax for no especially good reason)
  • Adding further to the diff ingester -- this is where the current trusty/osv data sources pull from. I think we'd prefer to have a more-general and less PR-linked data source, so preferring to move away from those.

Additional context

No response

Acceptance Criteria

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant