Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: webhook handlers convert all numerical types to float64 #965

Closed
jhrozek opened this issue Sep 15, 2023 · 1 comment
Closed

bug: webhook handlers convert all numerical types to float64 #965

jhrozek opened this issue Sep 15, 2023 · 1 comment
Labels
bug Something isn't working go Pull requests that update Go code good first issue Good for newcomers priority: low Low priority

Comments

@jhrozek
Copy link
Contributor

jhrozek commented Sep 15, 2023

Describe the bug
Following up on code-review in pull #952. We use the JQ accessor function to read numerical types but always pass in float64 as the type. For some reason, the type conversion to other fixed-width numerical types like int32 or int64 fails. We should investigate and fix the code to convert to the types used by the GH API as otherwise we risk under or overflows.
@jhrozek jhrozek added the bug Something isn't working label Sep 15, 2023
@jhrozek jhrozek mentioned this issue Sep 15, 2023
Merged
@jhrozek jhrozek added the priority: low Low priority label Oct 19, 2023
@rdimitrov rdimitrov added good first issue Good for newcomers go Pull requests that update Go code labels Oct 23, 2023
@rdimitrov rdimitrov changed the title webhook handlers convert all numerical types to float64 bug: webhook handlers convert all numerical types to float64 Oct 23, 2023
@dmjb dmjb mentioned this issue Feb 27, 2024
Merged
10 tasks
@evankanderson
Copy link
Member

We're replacing this code, and we already replaced most of this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working go Pull requests that update Go code good first issue Good for newcomers priority: low Low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jhrozek @evankanderson @rdimitrov