Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*hard* depends on default or mcl, not optionally #84

Open
TheEt1234 opened this issue May 19, 2024 · 1 comment
Open

*hard* depends on default or mcl, not optionally #84

TheEt1234 opened this issue May 19, 2024 · 1 comment

Comments

@TheEt1234
Copy link

Game: devtest

ModError: Failed to load and run script from /home/et/.minetest/mods/digilines/init.lua:
/home/et/.minetest/mods/digilines/inventory.lua:172: attempt to index field 'sounds' (a nil value)
stack traceback:
	/home/et/.minetest/mods/digilines/inventory.lua:172: in main chunk
	[C]: in function 'dofile'
	/home/et/.minetest/mods/digilines/init.lua:88: in main chunk
Check debug.txt for details.

Problematic segment: https://github.com/minetest-mods/digilines/blob/master/inventory.lua#L172C11-L172C54

Solution: If no default mod then no sound

@TheEt1234
Copy link
Author

TheEt1234 commented May 19, 2024

oh nevermind it's slightly different

if minetest.get_modpath("default") then digilines.sounds = default end
if digilines.mcl then digilines.sounds = mcl_sounds end

So it supports mineclone2 or default, nothing else
i think that should be made clear as an error message or just default to no sound

@TheEt1234 TheEt1234 changed the title *hard* depends on default, not optionally *hard* depends on default or mcl, not optionally May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant