NotImplemented support for Azure and cleanup issues #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebozduman
force-pushed
the
go-mint-failures
branch
from
a8a58fc to
aa864b5
Compare
3 tasks
ebozduman
force-pushed
the
go-mint-failures
branch
2 times, most recently
from
e36ce23 to
941aaf5
Compare
ebozduman
changed the title
kannappanr
approved these changes
Dec 22, 2020
poornas
approved these changes
Dec 22, 2020
ebozduman
force-pushed
the
go-mint-failures
branch
from
941aaf5 to
2d491f8
Compare
ebozduman
force-pushed
the
go-mint-failures
branch
from
2d491f8 to
32fdfe0
Compare
This was referenced Mar 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for minio-go mint tests when they are run against Azure (minio runs as a gateway).
Instead of skipping tests, it is better to have server respond with a
NotImplementederror message and handle it accordingly on the client side.This approach also needs a fix on the minio gateway side. The minio PR is minio/minio#10635.