lifecycle: Fix infinite NoncurrentTransition xml marshalling #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A missing type wrapper to avoid an infinite recursive call of MarshalXML is missing for NoncurrentTransition struct type. This commit will add it.
vadmeste
force-pushed
the
fix-lifecycle-xml-marshal
branch
from
48ab896 to
037979f
Compare
harshavardhana
approved these changes
Jan 7, 2021
This was referenced Mar 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A missing type wrapper to avoid an infinite recursive call of MarshalXML
is missing for NoncurrentTransition struct type. This commit will add
it.
Also add NoncurrentTransition.IsDaysNull() API similarly to NonCurrentExpiration.