Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow redirection with configurable parameter #2016

Closed
shivakumargowda12 opened this issue Nov 8, 2024 · 2 comments
Closed

Allow redirection with configurable parameter #2016

shivakumargowda12 opened this issue Nov 8, 2024 · 2 comments

Comments

@shivakumargowda12
Copy link

Its more of a suggestion than any issue/improvement.

Handling HTTP Redirect error is an important feature and widely used.
We clearly understand the intention to remove redirect handling support completely - minio/minio#13918.

Although, it fixed the issue faced during AWS S3 resource access across regions.
Minio Client SDK is being widely used for other Object Store vendors as well, which is not completely dependent on Regions.

My suggestion here is, why cant we make Redirection Handling as an optional configurable feature in minio-go (Setting Disabled by Default), so that whoever wants to make use of redirection they can continue using that feature without any hassle.

So, the changes needed would be simple

  • Reverting back the changeset - remove redirector for S3 API calls #1601
  • Add a configuration setting in minio to enable/disable redirect handling. (Disabled by default)
  • Add a check at redirection flow and proceed based on the config parameter
@harshavardhana
Copy link
Member

Redirection support is not part of S3 API and is out of scope for this SDK. Let me know if this supported in AWS SDK if yes we can bring it back otherwise sorry.

@harshavardhana
Copy link
Member

My suggestion here is, why cant we make Redirection Handling as an optional configurable feature in minio-go (Setting Disabled by Default), so that whoever wants to make use of redirection they can continue using that feature without any hassle.

We don't want to carry code that no one uses and will never use it properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants