Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.0.18 listObjects broken #886

Closed
PacoDu opened this issue Dec 16, 2020 · 7 comments · Fixed by #887
Closed

7.0.18 listObjects broken #886

PacoDu opened this issue Dec 16, 2020 · 7 comments · Fixed by #887

Comments

@PacoDu
Copy link

PacoDu commented Dec 16, 2020

Since 7.0.18 we are experiencing errors with minio client and listObjects. I think the issue was introduced by #877. Also I think there is an issue in the way #877 was merged because xml2js dependency is reintroduced which reverts part of #861

// ...
const res = await minioClient.listObjects(bucket, objectKey, true)
TypeError: xmlobj.Contents.forEach is not a function
    at parseListObjects (/app/node_modules/minio/dist/main/xml-parsers.js:387:21)
    at DestroyableTransform._flush (/app/node_modules/minio/dist/main/transformers.js:88:19)
    at DestroyableTransform.prefinish (/app/node_modules/readable-stream/lib/_stream_transform.js:138:10)
    at DestroyableTransform.emit (events.js:314:20)
    at prefinish (/app/node_modules/readable-stream/lib/_stream_writable.js:619:14)
    at finishMaybe (/app/node_modules/readable-stream/lib/_stream_writable.js:627:5)
    at endWritable (/app/node_modules/readable-stream/lib/_stream_writable.js:638:3)
    at DestroyableTransform.Writable.end (/app/node_modules/readable-stream/lib/_stream_writable.js:594:41)
    at IncomingMessage.onend (_stream_readable.js:683:10)
    at Object.onceWrapper (events.js:420:28)
@ebozduman
Copy link
Contributor

ebozduman commented Dec 16, 2020

@PacoDu

Yes. This is a regression due to #877. PR #887 fixes it.

issue in the way #877 was merged because xml2js dependency is reintroduced

We still use the faster xml parser, fxp, for parsing and get the benefit of its speed.
We had to bring back xml2js module, because we also need another functionality of it, conversion from json to xml, which does not come with fxp module.

@PacoDu
Copy link
Author

PacoDu commented Dec 16, 2020

@ebozduman Oh ok i see, thanks for the xml2js dependency explanation and the quick fix 🚀 !

@starpit
Copy link

starpit commented Feb 5, 2021

Is there a plan to release this fix in a 7.0.19?

@fschuetz04
Copy link

fschuetz04 commented Jun 12, 2021

Any update on this? The latest version is still 7.0.18, which does not include the mentioned fix. Whenever I use listObjects with a single result, the error occurs.

@prakashsvmx
Copy link
Member

@fschuetz04 we are planning for a release soon. Please stay tuned.

@gmacmaster
Copy link

Any ideas as to what soon will be?

@prakashsvmx
Copy link
Member

@kannappanr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants