Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtimeClassName support to Tenant CRD #1194

Closed
dnskr opened this issue Jul 2, 2022 · 6 comments · Fixed by #1217
Closed

Add runtimeClassName support to Tenant CRD #1194

dnskr opened this issue Jul 2, 2022 · 6 comments · Fixed by #1217

Comments

@dnskr
Copy link
Contributor

dnskr commented Jul 2, 2022

Is your feature request related to a problem? Please describe.
The feature request related to the problem with files relabeling when MinIO pods run on nodes with enabled SELinux.
The solution described in the discussion and require runtimeClassName to be set on MinIO pods.

Describe the solution you'd like
Support for runtimeClassName needs to be added to Tenant CRD and tenant helm chart.

@steve-gray
Copy link
Contributor

As per minio/minio#15217 and the associated discussions, without this work to enable skipping of most of the leg-work of an SELinux relabel, it's essentially impossible to use Minio in any modern managed Kubernetes environment. As most platforms default to an SELinux variant (EKS, OCI/EKS, AKS etc....), it essentially means a restart of Minio with a scaled number of files can take exponential amounts of time, and lead to low availability of the service.

@dnskr
Copy link
Contributor Author

dnskr commented Jul 22, 2022

@Alevsk @dvaldivia Hi! Are you planning to work on this issue any time soon? If not, I can try to do it. Unfortunately I'm not familiar with go and operator code base. So I would appreciate your guidance or just one or two similar PRs as the examples.

@dvaldivia
Copy link
Collaborator

@dnskr it's a sort of an easy issue, I can work on this before the next release v4.5.0 which is going to be release early next week, or you can give it a try

@dnskr
Copy link
Contributor Author

dnskr commented Jul 22, 2022

Great! In this case I would prefer to leave it to you, since I don't feel it's easy for me.

@dvaldivia
Copy link
Collaborator

@dnskr the PR is up, you can review it to get an idea on how to do this changes, it's sort of straight forward

@dvaldivia
Copy link
Collaborator

Most of the auto-generate code can be generated with our Makefile targets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants