Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matplotlib 2.0 may break regression tests on display module #233

Closed
bmcfee opened this issue Jan 19, 2017 · 3 comments · Fixed by #234
Closed

matplotlib 2.0 may break regression tests on display module #233

bmcfee opened this issue Jan 19, 2017 · 3 comments · Fixed by #234
Assignees

Comments

@bmcfee
Copy link
Collaborator

bmcfee commented Jan 19, 2017

Just putting this issue here, since the new release might change some of the default settings in ways that cause the regression tests to fail.

My advice is to update the build requirements for testing to matplotlib >= 2.0.0 and re-generate the test cases accordingly. People can still run code on 1.5, but testing should stay up to date.

@craffel
Copy link
Collaborator

craffel commented Jan 19, 2017

Ok, thanks.

re-generate the test cases accordingly

How did you generate the test cases in the first place?

@bmcfee
Copy link
Collaborator Author

bmcfee commented Jan 19, 2017

Ran the tests functions, checked the output manually, and then copied over to baseline images.

I can take care of this in a few days.

@craffel
Copy link
Collaborator

craffel commented Jan 19, 2017

Ok, cool.

@bmcfee bmcfee mentioned this issue Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants