Can't process Accept activity after Follow when `activity.actor` doesn't exist #12720

pfefferle · 2023-12-19T18:55:51Z

💡 Summary

I am the maintainer of the WordPress ActivityPub plugin: https://wordpress.org/plugins/activitypub/

I tried to follow my Blogs User Account and the process stucks "In progress". The Blog receives the Follow Request and also sends the Accept response and Misskey seem to be fine with the Accept:

[status_code] => 202
[protocol_version] => 1.1
[success] => 1
[redirects] => 0
[url] => https://misskey.io/inbox
[history] => Array()

When I try to refresh the profile I receive the following error:

Endpoint: federation/update-remote-user
Info: {"e":{"message":"Cannot perform update query because update values are not defined. Call \"qb.set(...)\" method to specify updated values.","code":"UpdateValuesMissingError","id":"636723f6-a119-4a1e-b824-346150f611bb"}}
Date: 2023-12-19T17:17:23.482Z

I already experimented with Misskey some 4 month ago without issues:

The IDs I tried are:

@[email protected] or https://notiz.blog/author/matthias-pfefferle/ (Person)
@[email protected] or https://notiz.blog/@notiz.blog (Group)

🥰 Expected Behavior

It should be possible to follow a User on a WordPress Blog and to refresh the profile informations.

🤬 Actual Behavior

See summary.

📝 Steps to Reproduce

Go to a misskey instance
search for @[email protected]
Press "Follow" button
Try to refresh the profile

💻 Frontend Environment

* Model and OS of the device(s): Mac OS X
* Browser: Firefox
* Server URL: https://misskey.io/
* Misskey: v2023.11.1-io.5a

🛰 Backend Environment (for server admin)

* Installation Method or Hosting Service: misskey.io
* Misskey: v2023.11.1-io.5a
* Node:
* PostgreSQL:
* Redis:
* OS and Architecture:

The text was updated successfully, but these errors were encountered:

saschanaz · 2023-12-20T14:27:57Z

Info: {"e":{"message":"Cannot perform update query because update values are not defined. Call "qb.set(...)" method to specify updated values.","code":"UpdateValuesMissingError","id":"636723f6-a119-4a1e-b824-346150f611bb"}}

That's definitely a TypeORM error 🤔

saschanaz · 2023-12-20T14:33:54Z

The server side log says:

WARN 1 [queue inbox] failed(TypeError: Cannot read properties of undefined (reading 'id')) id=288775 attempts=1/8 age=12ms activity=https://notiz.blog/author/matthias-pfefferle/...

id is undefined? 🤔🤔🤔🤔

pfefferle · 2023-12-20T14:36:19Z

So the ID-URI needs to be publicly accessible even for an Accept?

saschanaz · 2023-12-20T14:43:21Z

I'll have to dig more as I'm not very familiar with typeorm and the log doesn't say the line number, but the error should be from somewhere here or below:

misskey/packages/backend/src/core/activitypub/models/ApPersonService.ts

Lines 488 to 496 in 10d4ae1

    
           // Update user 
        
           await this.usersRepository.update(exist.id, updates); 
        
           if (person.publicKey) { 
        
           	await this.userPublickeysRepository.update({ userId: exist.id }, { 
        
           		keyId: person.publicKey.id, 
        
           		keyPem: person.publicKey.publicKeyPem, 
        
           	}); 
        
           }

Since the actor information is already fetched, the function just loads it from the local data, which should include the ID:

misskey/packages/backend/src/core/activitypub/models/ApPersonService.ts

Lines 417 to 418 in 10d4ae1

    
           const exist = await this.fetchPerson(uri) as MiRemoteUser | null; 
        
           if (exist === null) return;

So the ID-URI needs to be publicly accessible even for an Accept?

Per the above I would say no. Maybe the initial fetch for the actor goes wrong?

saschanaz · 2023-12-20T14:53:34Z

The server side log says:

WARN 1 [queue inbox] failed(TypeError: Cannot read properties of undefined (reading 'id')) id=288775 attempts=1/8 age=12ms activity=https://notiz.blog/author/matthias-pfefferle/...

id is undefined? 🤔🤔🤔🤔

Hmm, that one actually seems more like a general JS error. ~~Can exist be undefined, when the code checks only null? (== null is generally better IMO.)~~ (Edit: no, it may have totally different error stack starting from InboxProcessorService.process.)

saschanaz · 2023-12-20T20:08:54Z

When I try to refresh the profile I receive the following error:

Endpoint: federation/update-remote-user
Info: {"e":{"message":"Cannot perform update query because update values are not defined. Call \"qb.set(...)\" method to specify updated values.","code":"UpdateValuesMissingError","id":"636723f6-a119-4a1e-b824-346150f611bb"}}
Date: 2023-12-19T17:17:23.482Z

For this part, how did you trigger that endpoint? It's an admin-only endpoint that is hidden by bbef2a9 (🤔 cc @syuilo), are you manually creating the API request?

Anyway, I did the manual request and got the stack:

  e: {
    message: 'Cannot perform update query because update values are not defined. Call "qb.set(...)" method to specify updated values.',
    code: 'UpdateValuesMissingError',
    stack: 'UpdateValuesMissingError: Cannot perform update query because update values are not defined. Call "qb.set(...)" method to specify updated values.\n' +
      '    at UpdateQueryBuilder.createUpdateExpression (C:\\Users\\Kagami\\Documents\\GitHub\\hitoriskey\\node_modules\\.pnpm\\[email protected][email protected][email protected]\\node_modules\\typeorm\\query-builder\\UpdateQueryBuilder.js:430:19)\n' +
      '    at UpdateQueryBuilder.getQuery (C:\\Users\\Kagami\\Documents\\GitHub\\hitoriskey\\node_modules\\.pnpm\\[email protected][email protected][email protected]\\node_modules\\typeorm\\query-builder\\UpdateQueryBuilder.js:34:21)\n' +
      '    at UpdateQueryBuilder.getQueryAndParameters (C:\\Users\\Kagami\\Documents\\GitHub\\hitoriskey\\node_modules\\.pnpm\\[email protected][email protected][email protected]\\node_modules\\typeorm\\query-builder\\QueryBuilder.js:274:28)\n' +
      '    at UpdateQueryBuilder.execute (C:\\Users\\Kagami\\Documents\\GitHub\\hitoriskey\\node_modules\\.pnpm\\[email protected][email protected][email protected]\\node_modules\\typeorm\\query-builder\\UpdateQueryBuilder.js:81:50)\n' +
      '    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\n' +
      '    at async ApPersonService.updatePerson (file:///C:/Users/Kagami/Documents/GitHub/hitoriskey/packages/backend/built/core/activitypub/models/ApPersonService.js:412:9)\n' +
      '    at async file:///C:/Users/Kagami/Documents/GitHub/hitoriskey/packages/backend/built/server/api/endpoints/federation/update-remote-user.js:41:13\n' +
      '    at async ApiCallService.call (file:///C:/Users/Kagami/Documents/GitHub/hitoriskey/packages/backend/built/server/api/ApiCallService.js:316:16)',
    id: '52ae54be-ed51-45f8-a18c-71bbe31534fa'
  }

... which points to:

misskey/packages/backend/src/core/activitypub/models/ApPersonService.ts

Lines 519 to 523 in 10d4ae1

    
           // 該当ユーザーが既にフォロワーになっていた場合はFollowingもアップデートする 
        
           await this.followingsRepository.update( 
        
           	{ followerId: exist.id }, 
        
           	{ followerSharedInbox: person.sharedInbox ?? person.endpoints?.sharedInbox }, 
        
           );

saschanaz · 2023-12-20T20:14:38Z

curl -H 'Accept: application/activity+json' https://notiz.blog/author/matthias-pfefferle/ gives no sharedInbox indeed, which seems the cause for the update-remote-user endpoint at least. (Should it be required though? 🤔)

saschanaz · 2023-12-20T20:20:48Z

https://w3c.github.io/activitypub/#actor-objects

sharedInbox
An optional endpoint used for wide delivery of publicly addressed activities and activities sent to followers. sharedInbox endpoints SHOULD also be publicly readable OrderedCollection objects containing objects addressed to the Public special collection. Reading from the sharedInbox endpoint MUST NOT present objects which are not addressed to the Public endpoint.

So it should be optional.

saschanaz · 2023-12-20T22:42:09Z

With #12727 I get:

WARN 1  [queue inbox]   failed(TypeError: Cannot read properties of undefined (reading 'id')
    at getApId (file:///misskey/packages/backend/built/core/activitypub/type.js:23:22)
    at ApDbResolverService.parseUri (file:///misskey/packages/backend/built/core/activitypub/ApDbResolverService.js:46:29)
    at ApDbResolverService.getUserFromApId (file:///misskey/packages/backend/built/core/activitypub/ApDbResolverService.js:77:29)
    at ApInboxService.acceptFollow (file:///misskey/packages/backend/built/core/activitypub/ApInboxService.js:202:57)
    at ApInboxService.accept (file:///misskey/packages/backend/built/core/activitypub/ApInboxService.js:197:49)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async ApInboxService.performOneActivity (file:///misskey/packages/backend/built/core/activitypub/ApInboxService.js:141:13)
    at async ApInboxService.performActivity (file:///misskey/packages/backend/built/core/activitypub/ApInboxService.js:119:13)
    at async InboxProcessorService.process (file:///misskey/packages/backend/built/queue/processors/InboxProcessorService.js:167:9)
    at async Worker.processJob (/misskey/node_modules/.pnpm/[email protected]/node_modules/bullmq/dist/cjs/classes/worker.js:350:28)
    at async Worker.retryIfFailed (/misskey/node_modules/.pnpm/[email protected]/node_modules/bullmq/dist/cjs/classes/worker.js:535:24)) id=289285 attempts=1/8 age=12ms activity=https://notiz.blog/author/matthias-pfefferle/#follow-sekai.social/users/9ke0mh0ps3ln0008-1703112007

Which is:

misskey/packages/backend/src/core/activitypub/ApInboxService.ts

Lines 207 to 211 in 10d4ae1

    
           @bindThis 
        
           private async acceptFollow(actor: MiRemoteUser, activity: IFollow): Promise<string> { 
        
           	// ※ activityはこっちから投げたフォローリクエストなので、activity.actorは存在するローカルユーザーである必要がある 
        
           	const follower = await this.apDbResolverService.getUserFromApId(activity.actor);

Somehow activity.actor is undefined?

pfefferle · 2023-12-21T09:54:06Z

For this part, how did you trigger that endpoint?

I used the "Update remote user information" feature.

And the error stack was part of the response message.

(sharedInbox) So it should be optional.

Yes it is optional and even if it makes sense for bigger instances with a lot of users, it does not make sense for small WordPress instances with only some few users.

pfefferle · 2023-12-21T15:38:31Z

I experimented with a shared inbox and then I can at least run "Update remote user information" without issues, but following is still a problem.

I use the same URL for the Actor-ID and Actor-URL, could that be an issue for Misskey?

This is my other blog with the sharedInbox enabled if you need a test instance:

saschanaz · 2023-12-21T15:58:13Z

I think the following and update-remote thing is technically separate issues, but we'll see...

saschanaz · 2023-12-21T16:03:38Z

I use the same URL for the Actor-ID and Actor-URL, could that be an issue for Misskey?

That should be okay IMO. Can you check how the data look like for the Accept activity? Does it have actor field? I don't think this is required per the spec, though.

pfefferle · 2023-12-21T16:09:34Z

Here is an Accept example:

{
  "@context": [
    "https://www.w3.org/ns/activitystreams",
    "https://w3id.org/security/v1",
    {
      "manuallyApprovesFollowers": "as:manuallyApprovesFollowers",
      "PropertyValue": "schema:PropertyValue",
      "schema": "http://schema.org#",
      "pt": "https://joinpeertube.org/ns#",
      "toot": "http://joinmastodon.org/ns#",
      "webfinger": "https://webfinger.net/#",
      "litepub": "http://litepub.social/ns#",
      "lemmy": "https://join-lemmy.org/ns#",
      "value": "schema:value",
      "Hashtag": "as:Hashtag",
      "featured": {
        "@id": "toot:featured",
        "@type": "@id"
      },
      "featuredTags": {
        "@id": "toot:featuredTags",
        "@type": "@id"
      },
      "alsoKnownAs": {
        "@id": "as:alsoKnownAs",
        "@type": "@id"
      },
      "moderators": {
        "@id": "lemmy:moderators",
        "@type": "@id"
      },
      "postingRestrictedToMods": "lemmy:postingRestrictedToMods",
      "discoverable": "toot:discoverable",
      "indexable": "toot:indexable",
      "sensitive": "as:sensitive",
      "resource": "webfinger:resource"
    }
  ],
  "id": "https://pfefferle.org/author/pfefferle/#follow/1703174869",
  "type": "Accept",
  "object": {
    "id": "https://misskey.io/follows/9niynkoa4zjm0021",
    "type": "Follow"
  },
  "actor": "https://pfefferle.org/author/pfefferle/",
  "to": "https://misskey.io/users/7xgdnovq9y"
}

pfefferle · 2023-12-21T16:10:53Z

oh, it seems to miss the actor in the object... will check why this!

saschanaz · 2023-12-21T16:17:15Z

Technically Misskey should be able to infer the actor from the id https://misskey.io/follows/9niynkoa4zjm0021, but it seems the implementation totally ignores it as acceptFollow doesn't use it at all. 👀

pfefferle · 2023-12-21T16:23:31Z

@saschanaz You saved my day and my christmas holidays!!! I found the issue in the code that strips the actor and the object!

I will fix it asap and release a new update!

So the follow issue is solved, sorry for keeping you busy and thanks a lot for your help debugging this issue!

saschanaz · 2023-12-21T16:24:56Z

Congrats! 🎉

(Let's keep this issue open to track supporting implementations without those fields)

pfefferle · 2023-12-21T16:25:32Z

(Let's keep this issue to track supporting implementations without those fields)

Besides of that, should I keep this issue open because of the sharedInbox problem?

saschanaz · 2023-12-21T16:26:50Z

Yup, but ideally we should have two separate issues for each.

pfefferle · 2023-12-21T16:30:08Z

Ok, I will file a separate issue for the sharedInbox issue.

pfefferle added the ⚠️bug? This might be a bug label Dec 19, 2023

kakkokari-gtyih added packages/backend Server side specific issue/PR 🌌Federation The Federation/ActivityPub feature labels Dec 20, 2023

saschanaz mentioned this issue Dec 20, 2023

chore(QueueProcessorService): show error stack for failures #12727

Merged

5 tasks

saschanaz changed the title ~~Can't follow WordPress with ActivityPub plugin enabled~~ Can't process Accept activity after Follow when activity.actor doesn't exist Dec 21, 2023

saschanaz added 🐛Bug Unexpected behavior and removed ⚠️bug? This might be a bug labels Dec 22, 2023

This was referenced Nov 15, 2024

fix(backend): fallback sharedInbox to null in ApPersonService #14970

Merged

[GoToSocial] Aproving request from GtS appears with some delay #14915

Closed

samunohito added this to [実験中] 管理用 Nov 27, 2024

github-project-automation bot moved this to Todo in [実験中] 管理用 Nov 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Can't process Accept activity after Follow when `activity.actor` doesn't exist #12720

Can't process Accept activity after Follow when `activity.actor` doesn't exist #12720

pfefferle commented Dec 19, 2023

saschanaz commented Dec 20, 2023

saschanaz commented Dec 20, 2023

pfefferle commented Dec 20, 2023 •

edited

Loading

saschanaz commented Dec 20, 2023

saschanaz commented Dec 20, 2023 •

edited

Loading

saschanaz commented Dec 20, 2023 •

edited

Loading

saschanaz commented Dec 20, 2023 •

edited

Loading

saschanaz commented Dec 20, 2023

saschanaz commented Dec 20, 2023 •

edited

Loading

pfefferle commented Dec 21, 2023 •

edited

Loading

pfefferle commented Dec 21, 2023 •

edited

Loading

saschanaz commented Dec 21, 2023

saschanaz commented Dec 21, 2023

pfefferle commented Dec 21, 2023

pfefferle commented Dec 21, 2023

saschanaz commented Dec 21, 2023

pfefferle commented Dec 21, 2023

saschanaz commented Dec 21, 2023 •

edited

Loading

pfefferle commented Dec 21, 2023

saschanaz commented Dec 21, 2023

pfefferle commented Dec 21, 2023

Can't process Accept activity after Follow when activity.actor doesn't exist #12720

Can't process Accept activity after Follow when activity.actor doesn't exist #12720

Comments

pfefferle commented Dec 19, 2023

💡 Summary

🥰 Expected Behavior

🤬 Actual Behavior

📝 Steps to Reproduce

💻 Frontend Environment

🛰 Backend Environment (for server admin)

saschanaz commented Dec 20, 2023

saschanaz commented Dec 20, 2023

pfefferle commented Dec 20, 2023 • edited Loading

saschanaz commented Dec 20, 2023

saschanaz commented Dec 20, 2023 • edited Loading

saschanaz commented Dec 20, 2023 • edited Loading

saschanaz commented Dec 20, 2023 • edited Loading

saschanaz commented Dec 20, 2023

saschanaz commented Dec 20, 2023 • edited Loading

pfefferle commented Dec 21, 2023 • edited Loading

pfefferle commented Dec 21, 2023 • edited Loading

saschanaz commented Dec 21, 2023

saschanaz commented Dec 21, 2023

pfefferle commented Dec 21, 2023

pfefferle commented Dec 21, 2023

saschanaz commented Dec 21, 2023

pfefferle commented Dec 21, 2023

saschanaz commented Dec 21, 2023 • edited Loading

pfefferle commented Dec 21, 2023

saschanaz commented Dec 21, 2023

pfefferle commented Dec 21, 2023

Can't process Accept activity after Follow when `activity.actor` doesn't exist #12720

Can't process Accept activity after Follow when `activity.actor` doesn't exist #12720

pfefferle commented Dec 20, 2023 •

edited

Loading

saschanaz commented Dec 20, 2023 •

edited

Loading

saschanaz commented Dec 20, 2023 •

edited

Loading

saschanaz commented Dec 20, 2023 •

edited

Loading

saschanaz commented Dec 20, 2023 •

edited

Loading

pfefferle commented Dec 21, 2023 •

edited

Loading

pfefferle commented Dec 21, 2023 •

edited

Loading

saschanaz commented Dec 21, 2023 •

edited

Loading