Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-misskey-js-autogen may have problems #13147

Closed
1 task
dakkar opened this issue Feb 2, 2024 · 3 comments
Closed
1 task

check-misskey-js-autogen may have problems #13147

dakkar opened this issue Feb 2, 2024 · 3 comments
Labels
⚠️bug? This might be a bug

Comments

@dakkar
Copy link
Contributor

dakkar commented Feb 2, 2024

💡 Summary

check-misskey-js-autogen checks that the files in the PR and the re-generated files are identical.

But the files include the timestamp when they were generated, so they'll always be different

🥰 Expected Behavior

a PR with no changes to types, or a PR with changes generated by pnpm run build-misskey-js-with-types, should pass all its checks

🤬 Actual Behavior

https://github.com/misskey-dev/misskey/actions/runs/7757223154/job/21156225090?pr=13146 and https://github.com/misskey-dev/misskey/actions/runs/7757239915/job/21156270587?pr=13145 failed even after I ran pnpm run build-misskey-js-with-types

📝 Steps to Reproduce

No response

💻 Frontend Environment

No response

🛰 Backend Environment (for server admin)

No response

Do you want to address this bug yourself?

  • Yes, I will patch the bug myself and send a pull request
@dakkar dakkar added the ⚠️bug? This might be a bug label Feb 2, 2024
@zyoshoka
Copy link
Contributor

zyoshoka commented Feb 2, 2024

Since this problem is caused by the version bump (66714d9) and not timestamps, updating the branch seems to fix the problem. That said, need to add that to the message when CI fails.

@zyoshoka
Copy link
Contributor

zyoshoka commented Feb 6, 2024

misskey-js そのものには影響しないですし autogen 内の version の整合性チェックは取り除いても良い気がします。

Related to #13173

@zyoshoka
Copy link
Contributor

zyoshoka commented Feb 8, 2024

#13185 で対応されたので close して良さそうです。

@tamaina tamaina closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️bug? This might be a bug
Projects
None yet
Development

No branches or pull requests

3 participants