Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not be able to create empty string reaction #13804

Closed
1 task
zyoshoka opened this issue May 7, 2024 · 0 comments · Fixed by #13901
Closed
1 task

Should not be able to create empty string reaction #13804

zyoshoka opened this issue May 7, 2024 · 0 comments · Fixed by #13901
Assignees
@zyoshoka
Labels
🐛Bug Unexpected behavior 🔥high priority packages/backend Server side specific issue/PR

Comments

@zyoshoka
Copy link
Contributor

zyoshoka commented May 7, 2024

💡 Summary

notes/reactions/create において reaction パラメーターに空文字列 '' を指定してリアクションを作成することができてしまいます。

🥰 Expected Behavior

空文字列でリアクション作成できない

🤬 Actual Behavior

空文字列でリアクション作成できる

📝 Steps to Reproduce

No response

💻 Frontend Environment

No response

🛰 Backend Environment (for server admin)

* Installation Method or Hosting Service:
* Misskey: 2024.5.0-beta.1
* Node:
* PostgreSQL:
* Redis:
* OS and Architecture:

Do you want to address this bug yourself?

  • Yes, I will patch the bug myself and send a pull request
@zyoshoka zyoshoka added the ⚠️bug? This might be a bug label May 7, 2024
@acid-chicken acid-chicken added 🐛Bug Unexpected behavior packages/backend Server side specific issue/PR and removed ⚠️bug? This might be a bug labels May 7, 2024
@Sayamame-beans Sayamame-beans mentioned this issue May 19, 2024
Closed
1 task
@zyoshoka zyoshoka self-assigned this May 28, 2024
@zyoshoka zyoshoka mentioned this issue May 28, 2024
Merged
5 tasks
@t1nyb0x t1nyb0x moved this to Triage in [BUG TRACKER] Backend Jun 3, 2024
@github-project-automation github-project-automation bot moved this from Triage to Done in [BUG TRACKER] Backend Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zyoshoka zyoshoka

Labels
🐛Bug Unexpected behavior 🔥high priority packages/backend Server side specific issue/PR
Projects
No open projects
[BUG TRACKER] Backend
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(backend): fix creating reactions bugs zyoshoka/misskey
3 participants
@acid-chicken @kakkokari-gtyih @zyoshoka