Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] enable disableQueryTruncation (or other options?) for testing #15286

Conversation

anatawa12
Copy link
Member

What

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@anatawa12 anatawa12 marked this pull request as draft January 15, 2025 02:34
@anatawa12 anatawa12 changed the title [DO NOT MERGE] disable disableQueryTruncation (or other options?) for testing [DO NOT MERGE] enable disableQueryTruncation (or other options?) for testing Jan 15, 2025
@anatawa12
Copy link
Member Author

あーpackages/backend/**の変更がないから実行されてない〜

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jan 15, 2025
Copy link
Contributor

github-actions bot commented Jan 15, 2025

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.43%. Comparing base (002e939) to head (0da26c4).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #15286   +/-   ##
========================================
  Coverage    39.43%   39.43%           
========================================
  Files         1568     1568           
  Lines       199142   199145    +3     
  Branches      3656     3656           
========================================
+ Hits         78537    78542    +5     
+ Misses      120032   120030    -2     
  Partials       573      573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anatawa12
Copy link
Member Author

timelines.ts通ったね。

@anatawa12
Copy link
Member Author

highlightSql (highlight.highlight) に trancated な SQL を渡すと遅いのかもしれない

@samunohito
Copy link
Member

うーーーーーーーーーむ

@anatawa12
Copy link
Member Author

手元で雑に試す感じだと遅くなるの再現できないのでなんか秘孔があるのかもしれない

@anatawa12
Copy link
Member Author

とりあえずこのブランチの役目は終えたのでclose

@anatawa12 anatawa12 closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

2 participants