Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z-index when markers + virtual tour is enabled #1337

Closed
PanierAvide opened this issue Jun 25, 2024 · 2 comments
Closed

Z-index when markers + virtual tour is enabled #1337

PanierAvide opened this issue Jun 25, 2024 · 2 comments
Labels
Milestone

Comments

@PanierAvide
Copy link

Describe the bug

When both Virtual Tour Plugin and Markers Plugins are enabled, the div of markers has a lower value for z-index than virtual tour arrows, making markers not hoverable/clickable. This is reproducible in default demo of Virtual Tour Plugin in docs.

Changing .psv-markers z-index to 12 solves the issue.

Online demo URL

No response

Photo Sphere Viewer version

5.8.0

Plugins loaded

VirtualTourPlugin, MarkersPlugin

OS & browser

At least Firefox 127 under Linux

Additional context

No response

@PanierAvide
Copy link
Author

Well the fix is more subtle, as both virtual tour arrows & markers div have a full width/height sizing, so whatever the z-index is, one make the other not clickable. I have a working solution with:

.psv-markers { /* markers above + click events going through */
	z-index: 12 !important;
	pointer-events: none;
}
.psv-markers .psv-marker { /* restore clicks events on markers individually */
	pointer-events: initial;
}

@mistic100 mistic100 added this to the 5.8.1 milestone Jun 25, 2024
Copy link

This feature/bug fix has been released in version 5.8.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants