Retrieving nodes from config

[Mr-Kanister]

Describe your problem

Is it necessary to delete the nodes of the virtual-tour-plugin config object here?

Photo-Sphere-Viewer/packages/virtual-tour-plugin/src/VirtualTourPlugin.ts

Line 214 in 788c766

delete this.config.nodes;

I'd like to retrieve all nodes after the viewer has been loaded and don't want to use another fetch request to parse them if somehow possible.

Online demo URL

No response

Photo Sphere Viewer version

5.11.4

Plugins loaded

Virtual-Tour

Additional context

No response

[mistic100]

I always try to cleanup data I dont use anymore.

What don't you make a copy yourself ?

You can also access virtualTourPlugin.datasource.nodes if needed.

[Mr-Kanister]

I understand. I must say however, that this behaviour is quite unintuitive, at least for me. The config property is public and of Type VirtualTourPluginConfig with no sign of manual removal of the nodes.

The copy is of course doable, however, it is sometimes a bit annoying to “pass through” the copy to any function in need.

The datasource property is private, so I'd rather not use that in TS...

[mistic100]

Sorry I don't really understand the problem. The config property is already a copy of your initial config, yes it is public, but it is still internal to the plugin.

You should remain owner of the data you need, so keep the original config object in your app.

[Mr-Kanister]

Valid view, thanks.