Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change required for Blockly 11.2.0 #81

Closed
1 task done
MikeJDeck opened this issue Jan 9, 2025 · 1 comment
Closed
1 task done

Change required for Blockly 11.2.0 #81

MikeJDeck opened this issue Jan 9, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@MikeJDeck
Copy link

MikeJDeck commented Jan 9, 2025

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

I found that the plugin will fail in Blockly 11.2.0.
I tested the following fix in a local branch.
Replace the line:
if (!Blockly.ContextMenuRegistry.registry.registry_.workspaceSelectAll) {
with
if (!Blockly.ContextMenuRegistry.registry.getItem('workspaceSelectAll')) {

That was the line throwing the error.
I tested this fix in Blockly 11.0.0, 11.1.1, and 11.2.0

Reproduction steps

  1. Try the plugin with Blockly 11.2.0
  2. Note the error.

Stack trace

No response

Screenshots

No response

Browsers

No response

@MikeJDeck MikeJDeck added the bug Something isn't working label Jan 9, 2025
@HollowMan6
Copy link
Collaborator

Thank you for pointing this out! This is supposed to be updated already when we support Blockly v11 but we forgot to do so in #62!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants