-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differences between MD4C and GFM tables #136
Comments
I'm aware of this one. There is some ironic history involved.
To be honest, I'm quite reluctant to follow unless reality (say, a wider and clear consensus of other implementation) forces me to; AFAIK their reasoning is based on commonmark precedence rule. My counter-argument is that although in HTML the table cells are block elements, in GFM they behave more like inline spans on the Markdown side and that's what matters here because we are a Markdown parser, not a HTML parser.
Maybe they added some new examples into their specs. I don't remember this rule/example at all. Their specs additions were always heavily under-specified, so it's good if they make the things clearer.
This is more about the renderer, but makes sense too. |
Your reasoning makes a lot of sense to me, and I think it's more in line with the way most people (including me) would expect Markdown to work. |
Opened two new reports, so we can track/discuss/close the issue individually. So closing this one. |
I notice there are a few examples for tables in the GFM spec that differ from the way MD4C handles them. I saw that
test/tables.txt
differs from the GFM spec quite a bit, so I'm not sure if these differences are intentional or not. I know there's some other issues with tables in the GFM spec (e.g. the ones mentioned in #108).Example 200: Pipes in a cell's content must be escaped, even inside other spans. This one is surprising:
GFM Spec:
MD4C:
Example 203: Number of header columns must match the columns in the delimiter row.
GFM Spec:
MD4C:
Example 205:
<tbody>
tags must be omitted when the table has no body rows.GFM Spec:
MD4C:
The text was updated successfully, but these errors were encountered: