Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash (segfault) when using empty directory as resourcePath #10461

Closed
mixxxbot opened this issue Aug 23, 2022 · 8 comments
Closed

Crash (segfault) when using empty directory as resourcePath #10461

mixxxbot opened this issue Aug 23, 2022 · 8 comments
Labels
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: ehmic
Date: 2021-07-03T11:08:41Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1934560
Attachments: gdb.txt


Mixxx crashes when 'resourcePath' points to either an empty, or a non existing directory.
("mixxx" received signal SIGSEGV, Segmentation fault).

The 'Mixxx - Critical error' popup window appears correctly, stating that the skin directory is missing. After clicking 'OK' Mixxx tries to open, but crashes.
Maybe a better default behaviour would be to stop Mixxx when a critical error appears?

@mixxxbot
Copy link
Collaborator Author

Commented by: ehmic
Date: 2021-07-03T11:12:20Z
Attachments: gdb.txt


Here is the gdb output.

@mixxxbot mixxxbot added the bug label Aug 23, 2022
@mixxxbot
Copy link
Collaborator Author

Commented by: Holzhaus
Date: 2021-07-03T11:25:52Z


What Mixxx version does this affect? I cannot tell from the log (we should add an Info message).

Please copy the version (and git version string) from the about dialog.

@mixxxbot
Copy link
Collaborator Author

Commented by: ehmic
Date: 2021-07-03T12:57:00Z


Ah sorry, forgot to mention...

Version is: 2.3.0-8-gd3052f4fc5

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2021-07-29T11:58:46Z


main terminates regularly without a crash after a bunch of warnings and debug assertions:

warning [Main] Failed to load default skin "LateNight"
critical [Main] DEBUG ASSERT: "m_pSkin != nullptr" in function DlgPrefInterface::DlgPrefInterface(QWidget*, std::shared_ptr<mixxx::ScreensaverManager>, std::shared_ptr<mixxx::skin::SkinLoader>, UserSettingsPointer) at ../src/preferences/dialog/dlgprefinterface.cpp:48

critical [Main] "Skin directory does not exist: /tmp/mixxx_empty_res/skins"
critical [Main] DEBUG ASSERT: "pSkin && pSkin->isValid()" in function mixxx::skin::SkinPointer mixxx::skin::SkinLoader::getConfiguredSkin() const at ../src/skin/skinloader.cpp:122

warning [Main] Failed to load default skin "LateNight"
critical [Main] DEBUG ASSERT: "pSkin != nullptr && pSkin->isValid()" in function QWidget* mixxx::skin::SkinLoader::loadConfiguredSkin(QWidget*, QSet<ControlObject*>*, mixxx::CoreServices*) at ../src/skin/skinloader.cpp:145

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2021-07-29T12:49:46Z


2.3 crashes after an assertion:

Debug [Main]: =====================================
Debug [Main]: 0 ms stopping pending Library tasks
Critical [Main]: DEBUG ASSERT: "m_pScanner" in function void TrackCollectionManager::stopLibraryScan() at ../src/library/trackcollectionmanager.cpp:172

Thread 1 "mixxx" received signal SIGSEGV, Segmentation fault.

@mixxxbot
Copy link
Collaborator Author

Commented by: uklotzde
Date: 2021-07-29T13:48:59Z


Probably difficult to fix for 2.3 and not worth the effort.

@mixxxbot
Copy link
Collaborator Author

Commented by: daschuer
Date: 2021-12-21T11:28:22Z


#4575

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.3.2 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant