wrong sized loops

[mixxxbot]

Reported by: ywwg
Date: 2021-09-27T20:14:26Z
Status: Fix Committed
Importance: Medium
Launchpad Issue: lp1945238
Attachments: [Screenshot from 2021-09-27 16-13-22.png](https://bugs.launchpad.net/bugs/1945238/+attachment/5528513/+files/Screenshot from 2021-09-27 16-13-22.png)

---

On a particular track, loop sizes create at the main cue point are messed up for some reason. A 1-beat loop is 2 beat. A 2-beat loop is 3. 8 beat loop? 9 beats. Sub-beat loops are ok. this doesn't seem to happen anywhere else in the track

[mixxxbot]

Commented by: ywwg
Date: 2021-09-27T20:14:26Z
Attachments: [Screenshot from 2021-09-27 16-13-22.png](https://bugs.launchpad.net/mixxx/+bug/1945238/+attachment/5528513/+files/Screenshot from 2021-09-27 16-13-22.png)

[mixxxbot]

Commented by: Be-ing
Date: 2021-09-27T21:25:12Z

---

Does this occur on the 2.3 branch, main branch, or both? If it is only on the main branch it is likely related to the recent Beats refactoring.

Potentially related: https://bugs.launchpad.net/mixxx/+bug/1942657

[mixxxbot]

Commented by: ywwg
Date: 2021-09-28T00:48:23Z

---

main only, not 2.3. I'm guessing there is an edge-case of rounding up instead of down somewhere.

[mixxxbot]

Commented by: ywwg
Date: 2021-09-28T00:50:27Z

---

(And this is a const beatgrid track)

[mixxxbot]

Commented by: Be-ing
Date: 2021-09-28T04:01:26Z

---

That would be a plausible explanation for both this and https://bugs.launchpad.net/mixxx/+bug/1942657

[mixxxbot]

Commented by: ywwg
Date: 2021-09-28T14:23:05Z

---

This issue is caused by this commit: 95f7d36

Because Floating Point, sometimes the math is not perfect. In my case, the 4th beat is calculated as .001 past the 4th calculated beat, and therefore the ceiling call rounds up to the next whole beat. The previous fuzzy logic ensured that we would not do that.

[mixxxbot]

Commented by: ywwg
Date: 2021-09-28T14:27:22Z

---

reverting the commit fixes the issue, I will file a PR

[mixxxbot]

Commented by: daschuer
Date: 2021-10-11T17:20:41Z

---

This fixes the root cause:
#4366

[mixxxbot]

Issue closed with status Fix Committed.