Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Change OpenAI protocol default value to NOT_GIVEN #2114

Closed
tqchen opened this issue Apr 10, 2024 · 6 comments
Closed

[Feature Request] Change OpenAI protocol default value to NOT_GIVEN #2114

tqchen opened this issue Apr 10, 2024 · 6 comments
Assignees
Labels
feature request New feature or request

Comments

@tqchen
Copy link
Contributor

tqchen commented Apr 10, 2024

🚀 Feature

As of now OpenAI API protocol set the direct default values. From the endpt pov, it is better to set most values to be NOT_GIVEN, as per specified, then the backend would be able to supply model specific configurations if the configuration has not been passed in from the fronend.

@tqchen tqchen added the feature request New feature or request label Apr 10, 2024
@tqchen
Copy link
Contributor Author

tqchen commented Apr 10, 2024

@rickzx
Copy link
Contributor

rickzx commented Apr 19, 2024

#2178

@tqchen
Copy link
Contributor Author

tqchen commented Apr 20, 2024

let us also confirm if it is the case for JSONFFIEngine

@rickzx
Copy link
Contributor

rickzx commented Apr 25, 2024

@tqchen PR to change this in JSONFFIEngine: #2225

@rickzx rickzx closed this as completed Apr 26, 2024
@tqchen tqchen reopened this Apr 27, 2024
@tqchen
Copy link
Contributor Author

tqchen commented Apr 27, 2024

Just to followup on the case of JSONFFIEngine. The main purpose of JSONFFIEngine is that we should avoid passing in object and parsing mlc-chat-config from FFI side. so the current implemetation that relies on parsing and passing the default config from python side is not too desirable.

Instead, we should populate these values during JSONFFIEngine.reload inside the c++ implementation. This is to help the JSONFFIEngine default behavior to be useful across backends(such as iOS). can you followup with that?

@tqchen
Copy link
Contributor Author

tqchen commented May 11, 2024

@MasterJH5574 would be good to confirm the state of this issue now in JSONFFI

@tqchen tqchen closed this as completed Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants