Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding validation check for meta files #45

Open
anandhu-eng opened this issue Dec 12, 2024 · 3 comments
Open

Adding validation check for meta files #45

anandhu-eng opened this issue Dec 12, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@anandhu-eng
Copy link
Contributor


Migrated from mlcommons/mlperf-automations_archived#39
Originally created by @arjunsuresh on Thu, 26 Jan 2023 16:41:42 GMT


CM scripts can fail with unexpected errors if there is a syntax error in _cm.json/_cm.yaml files. It'll be good to add a quick syntax check for these files.

@anandhu-eng anandhu-eng added the enhancement New feature or request label Dec 12, 2024
@anandhu-eng
Copy link
Contributor Author


Migrated from mlcommons/mlperf-automations_archived#39 (comment)
Originally created by @gfursin on Sat, 28 Jan 2023 14:57:07 GMT


Oh, yes, that's very important! The idea of CK/CM is to enable very quick prototyping of ideas while gradually adding tests and safety including information about types. There are several ways of doing it. Let's discuss it at one of our future conf-calls. I agree that it becomes important now. Thanks a lot!

@anandhu-eng
Copy link
Contributor Author


Migrated from mlcommons/mlperf-automations_archived#39 (comment)
Originally created by @arjunsuresh on Sat, 28 Jan 2023 14:44:42 GMT


Hi @gfursin , actually I'm referring to the internal semantics specific to CM like the type of tags being a string, env being a dict, deps being a list, adr being a dict etc. Sure, we can discuss this.

@anandhu-eng
Copy link
Contributor Author


Migrated from mlcommons/mlperf-automations_archived#39 (comment)
Originally created by @gfursin on Thu, 26 Jan 2023 16:53:38 GMT


Interesting. I think scripts will report an error in the _cm.json/_cm.yaml file if there is a syntax error? Do you mean that we should we make error more user-friendly? Or you want some extra syntax check? We can discuss it during the conf-call ... Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant