Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About regular vs custom emojis #91

Closed
Laiteux opened this issue Aug 27, 2023 · 5 comments · Fixed by #96
Closed

About regular vs custom emojis #91

Laiteux opened this issue Aug 27, 2023 · 5 comments · Fixed by #96
Labels
good first issue Good for newcomers report Related to the report page

Comments

@Laiteux
Copy link

Laiteux commented Aug 27, 2023

msedge_bXTPjGYGN3

Shouldn't :pepe: be replaced by :heart: here, wouldn't that make more sense?

@Laiteux
Copy link
Author

Laiteux commented Aug 27, 2023

Same here, and then maybe in other places as well

msedge_J8qjZGVe5U

@hopperelec
Copy link
Contributor

No- :pepe: is to represent custom emojis, and the heart/fire are default so would not make sense there. Although I would say it could make sense to replace fire with hearts or replace the heart with fire.

@Laiteux
Copy link
Author

Laiteux commented Aug 27, 2023

Oh, it wasn't clear to me that this was supposed to represent custom emojis. Ok, guess it makes a lil more sense now.

@mlomb
Copy link
Owner

mlomb commented Sep 1, 2023

it could make sense to replace fire with hearts or replace the heart with fire.

I agree. Since it is a very small change I'll slip it in the next update (whenever it may be).
I'll leave this open until then :)

@mlomb mlomb changed the title cant think of a name rlly sry didnt sleep pls rename 🥺 About regular vs custom emojis Sep 1, 2023
@mlomb mlomb added good first issue Good for newcomers app Related to the Web app labels Sep 1, 2023
@Laiteux
Copy link
Author

Laiteux commented Sep 1, 2023

thanks for using your brain when i couldn't.

@mlomb mlomb added report Related to the report page and removed app Related to the Web app labels Sep 2, 2023
@mlomb mlomb closed this as completed in #96 Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers report Related to the report page
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants