Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust library so name can not match as module name? #3

Closed
oowl opened this issue Jun 28, 2023 · 3 comments
Closed

rust library so name can not match as module name? #3

oowl opened this issue Jun 28, 2023 · 3 comments

Comments

@oowl
Copy link

oowl commented Jun 28, 2023

in our use case, opendal is Lua module name. opendal build output as libopendal_lua.so

So I want to use the rocks build module opendal, For the current implement, if we want to build module as opendal, the backend library name is libopendal.so

Is any work around to implement this?

@oowl
Copy link
Author

oowl commented Jun 28, 2023

PR context in here apache/opendal#2558

╰─$ luarocks make --local           

opendal 0.1.0-1 depends on lua >= 5.1 (5.4-1 provided by VM)
opendal 0.1.0-1 depends on luarocks-build-rust-mlua (0.1.1-1 installed)
    Finished release [optimized] target(s) in 0.12s

Error: Build error: Failed installing ../../target/release/libopendal.so in /home/ouyang/.luarocks/lib/luarocks/rocks-5.4/opendal/0.1.0-1/lib/opendal.so: ../../target/release/libopendal.so: No such file or directory

@khvzak
Copy link
Member

khvzak commented Jun 28, 2023

@oowl I crated a PR #4 that should solve this case. Could you take a look

@khvzak
Copy link
Member

khvzak commented Jun 29, 2023

v0.1.2 published

@khvzak khvzak closed this as completed Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants