Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of FieldData #1

Open
nDimensionalSpace opened this issue Sep 2, 2021 · 3 comments · May be fixed by #2
Open

Addition of FieldData #1

nDimensionalSpace opened this issue Sep 2, 2021 · 3 comments · May be fixed by #2
Assignees
@nDimensionalSpace

Comments

@nDimensionalSpace
Copy link

Any issues with me adding the ability to write a bit of global data, via the FieldData element? Attached screenshot indicates what I am thinking . . . Thx.

Screen Shot 2021-09-02 at 11 11 46 AM
@nDimensionalSpace
Copy link
Author

Now that I look at the screenshot more carefully, I will say the following:

  • I won't use self-closing tags, and will use separate, explicit closing tags, per the current formatting convention.
  • I wouldn't bother with the string array element, as that is likely an extension for our particular case. I really just want to get the float guy in there.

@mmorse1217
Copy link
Owner

Sure, that would be great! Feel free to make a pull request with your additions and, if you can, add a test so that I can verify the expected behavior before merging.

@nDimensionalSpace
Copy link
Author

Heh, lets see if I did the fork+PR thing correctly . . .

@nDimensionalSpace nDimensionalSpace linked a pull request Sep 14, 2021 that will close this issue
Open
mmorse1217 pushed a commit that referenced this issue Jan 23, 2023
@shane-riley
Merge pull request #1 from OpenViewFactor/sriley/gitignore
c3627b5 
Add gitignore for easier use as a submodule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nDimensionalSpace nDimensionalSpace

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Initial functionality to write VTK FieldData nDimensionalSpace/lean-vtk
2 participants
@mmorse1217 @nDimensionalSpace