Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow calibration and ctc files to be None #1057

Merged
merged 16 commits into from
Feb 26, 2025
Merged

Conversation

harrisonritz
Copy link
Contributor

@harrisonritz harrisonritz commented Feb 23, 2025

Trying to push Cerca OPM data through the pipeline.

We don't have calibration or ctc files for our OPM system. IIUC Seems like both are necessary, because we 1) estimate sensor orientations during coreg (so raw.info should be 'correct') and 2) we only use magnetometers.

The MNE maxwell functions allow for calibration and cross_talk to be passed as None, so should be allowed here as well.

Before merging …

  • Changelog has been updated (docs/source/dev.md.inc)

allow for config and ctc to be set to None
Copy link

welcome bot commented Feb 23, 2025

Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴🏽‍♂️

@larsoner
Copy link
Member

@harrisonritz
Copy link
Contributor Author

I had to remove mf_ctc_fname & mf_cal_fname from in_files, and load them through the maxwell_filter.
This was already the approach in find_bad_channels_maxwell.

@harrisonritz
Copy link
Contributor Author

looks like this is passing 👍

@harrisonritz
Copy link
Contributor Author

ok, this implements mf_cal_missing + mf_ctc_missing, and adds a new test for them.

Copy link
Member

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit for a change that was proving tricky to pull off in the GH diff editor. Other comments are below.
Note that I've intentionally tweaked the config docstrings differently: it's a bigger deal for MEGIN systems if the crosstalk file is missing, than if finecal is missing. Happy to change that though if @larsoner disagrees.

I'll approve the CIs now and see how we do!

@harrisonritz
Copy link
Contributor Author

looks good, thanks!

Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committed @drammock 's suggestions and marking for merge-when-green, thanks in advance @harrisonritz !

@larsoner larsoner enabled auto-merge (squash) February 26, 2025 16:56
@larsoner larsoner merged commit 30c7798 into mne-tools:main Feb 26, 2025
60 of 61 checks passed
Copy link

welcome bot commented Feb 26, 2025

🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants