-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow calibration and ctc files to be None #1057
Conversation
allow for config and ctc to be set to None
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴🏽♂️ |
Seems reasonable to me! Failures look real/related now, can you look? For example |
I had to remove |
looks like this is passing 👍 |
ok, this implements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a commit for a change that was proving tricky to pull off in the GH diff editor. Other comments are below.
Note that I've intentionally tweaked the config docstrings differently: it's a bigger deal for MEGIN systems if the crosstalk file is missing, than if finecal is missing. Happy to change that though if @larsoner disagrees.
I'll approve the CIs now and see how we do!
looks good, thanks! |
Co-authored-by: Daniel McCloy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Committed @drammock 's suggestions and marking for merge-when-green, thanks in advance @harrisonritz !
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
Trying to push Cerca OPM data through the pipeline.
We don't have calibration or ctc files for our OPM system. IIUC Seems like both are necessary, because we 1) estimate sensor orientations during coreg (so raw.info should be 'correct') and 2) we only use magnetometers.
The MNE maxwell functions allow for
calibration
andcross_talk
to be passed as None, so should be allowed here as well.Before merging …
docs/source/dev.md.inc
)