Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Split bad-finding step #666

Merged
merged 7 commits into from
Nov 20, 2022
Merged

MAINT: Split bad-finding step #666

merged 7 commits into from
Nov 20, 2022

Conversation

larsoner
Copy link
Member

@larsoner larsoner commented Nov 16, 2022

Before merging …

  • Separate bad-finding into its own step
  • Add raw data plots to report (before preproc)
  • Fix logic with exec_params by including it in the kwargs, but excluding it from cache via ignore arg in memory.cache(...).
  • Restore grand-average source space report that was missing/dropped accidentally
  • Add bad-channel finding and use for empty-room data
  • Changelog has been updated (docs/source/changes.md)

Closes #657

It (hopefully) simplifies a bit the file logic. Let's see what the CIs say.

@larsoner larsoner added this to the 0.1 milestone Nov 16, 2022
@larsoner larsoner marked this pull request as draft November 17, 2022 00:14
@larsoner larsoner marked this pull request as ready for review November 19, 2022 17:04
@larsoner
Copy link
Member Author

Okay @hoechenberger this one is finally green and ready to go I think.

Some stuff might be simplified by having _01_data_quality.py write out a new _raw.fif with the break annotations, bads, etc. applied to it. But I wasn't sure if the extra storage space required would be worth it. Maybe in some follow-up PR...

@hoechenberger
Copy link
Member

Some stuff might be simplified by having _01_data_quality.py write out a new _raw.fif with the break annotations, bads, etc. applied to it. But I wasn't sure if the extra storage space required would be worth it.

We could use write_raw_bids() with symlink=True but yes, that's probably something for a followup PR!

@hoechenberger hoechenberger merged commit 5941829 into mne-tools:main Nov 20, 2022
@hoechenberger
Copy link
Member

Thanks @larsoner!

@larsoner larsoner deleted the bads branch November 20, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reports do not contain unfiltered data
2 participants