-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Black, ruff, pre-commit #688
Conversation
0aca705
to
333d921
Compare
I'm going to assume this is some weird GitHub problem and try again tomorrow... |
Ahh, GH is degraded at the moment:
|
@@ -452,7 +452,7 @@ | |||
``` | |||
""" | |||
|
|||
min_break_duration: float = 15. | |||
min_break_duration: float = 15.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hah, nice!!!
ArbitraryContrast | ||
] | ||
] = [] | ||
contrasts: Iterable[Union[Tuple[str, str], ArbitraryContrast]] = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So difficult to read. Time to drop support for Python <3.10 so we can use X | Y
instead of Union[X, Y]
😎
No but really, here we'd really gain a usability boost from a switch... maybe next spring or so??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My vote is to go with whenever MNE-Python switches to 3.10 as the min based on EOL
I temporarily enabled merge commits for the repo so we can merge this one rather than rebase+merge or squash+merge. I also removed the |
why not split out the |
Okay with me |
This might actually be the better idea 🤓 |
It's certainly another way to do it, but more work at this point. But since @hoechenberger is also for it, I'll do it that way |
Closes #686
Should be merged rather than squash-and-merged so that the
black
reformatting commit is ignored properly.